Adds required/optional tag option to accordion #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying radiance-ui with
|
| Latest commit: |
073f20d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f672fd5.radiance-ui.pages.dev |
| Branch Preview URL: | https://iris-ge-3328-accordion-requi.radiance-ui.pages.dev |
| /** show if the photo is required */ | ||
| isRequired?: boolean; | ||
| /** when true, shows Required/Optional tag */ | ||
| showRequiredTag?: boolean; |
There was a problem hiding this comment.
I might change the name of showRequiredTag to something like displayRequiredOrOptionalText.
The naming as is feels too similar to isRequired. Even with the comment block, I didn't fully understand the point of having both variables until looking at the actual code that references them.
There was a problem hiding this comment.
good idea, I'll make the change!
CurologyJonathanHartley
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isRequiredwill show the text "Required" or "Optional" if theshowRequiredTagproperty is set to "true"